url: process crash via malformed UNC hostname in pathToFileURL()#62574
Open
NickNaso wants to merge 3 commits intonodejs:mainfrom
Open
url: process crash via malformed UNC hostname in pathToFileURL()#62574NickNaso wants to merge 3 commits intonodejs:mainfrom
NickNaso wants to merge 3 commits intonodejs:mainfrom
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
c++
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #62574 +/- ##
==========================================
+ Coverage 89.69% 89.79% +0.10%
==========================================
Files 695 697 +2
Lines 214417 215776 +1359
Branches 41059 41301 +242
==========================================
+ Hits 192321 193760 +1439
+ Misses 14156 14115 -41
+ Partials 7940 7901 -39
🚀 New features to boost your workflow:
|
src/node_url.cc
Outdated
| CHECK(args[0]->IsString()); // href | ||
| CHECK(args[1]->IsNumber()); // action type | ||
| CHECK(args[2]->IsString()); // new value | ||
| CHECK(args[0]->IsString()); // href |
Contributor
There was a problem hiding this comment.
can you clean up whitespaces from the diff?
Renegade334
reviewed
Apr 7, 2026
Member
Renegade334
left a comment
Renegade334
left a comment
There was a problem hiding this comment.
LGTM but please revert the unrelated whitespace changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds che check to verify for the valid hostname and if not throw
ERR_INVALID_URLinstead of crash the process withCHECK(out->set_hostname(hostname.ToStringView()));.Fixes: #62546